Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.17] add-gauron #1095

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1063

/assign dsimansk

Signed-off-by: David Fridrich <[email protected]>
@dsimansk
Copy link
Collaborator

/approve
/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.17@4e4eee0). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.17    #1095   +/-   ##
================================================
  Coverage                 ?   64.57%           
================================================
  Files                    ?      131           
  Lines                    ?    15614           
  Branches                 ?        0           
================================================
  Hits                     ?    10083           
  Misses                   ?     4553           
  Partials                 ?      978           
Flag Coverage Δ
e2e-test 36.27% <ø> (?)
e2e-test-runtime-go 26.27% <ø> (?)
e2e-test-runtime-node 25.68% <ø> (?)
e2e-test-runtime-python 25.68% <ø> (?)
e2e-test-runtime-quarkus 25.82% <ø> (?)
e2e-test-runtime-rust 24.78% <ø> (?)
e2e-test-runtime-springboot 24.80% <ø> (?)
e2e-test-runtime-typescript 25.78% <ø> (?)
integration-tests 51.65% <ø> (?)
unit-tests 50.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gauron99
Copy link

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, gauron99, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek matejvasek merged commit 3c70e2c into openshift-knative:release-v1.17 Feb 13, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants