Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create e2e tests for new NRO related information collected in must-gather-pao #330

Open
jlojosnegros opened this issue Jul 13, 2022 · 3 comments
Assignees

Comments

@jlojosnegros
Copy link
Contributor

We needed to collect new must-gather data related to NRO.
After some discussion it was decided to do it in the must-gather-pao. openshift-kni/performance-addon-operators#919

Now we need to run some e2e tests to ensure it works properly.

As this needs NRO to be installed in the test environment these tests should run in NRO CI and should run nightly or weekly.

GH scheduled actions

See this comment for additional info

@jlojosnegros
Copy link
Contributor Author

/assign jlojosnegros

@jlojosnegros
Copy link
Contributor Author

openshift-kni/performance-addon-operators#919 (comment)
@fromanirh

I was wondering how could we test this.
I have thought in creating a new test that will create NRO and SCHED and then somehow run the PAO script and check at least the existence of some files.

My problem is I don't really know how to execute a PAO script from the NRO tests.

@ffromani
Copy link
Member

I think for a e2e test you should just consume the pre-built PAO MG image.
The main complication is making sure you have the oc binary available (but this can be addressed at lane configuration stage I believe). other than that it's about running an external command and checking the result.
Maybe check you have it when the test runs (handling the error if not -> fail the test - or skip? your call)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants