e2e:must-gather: Get NRO namespace from status #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlojosnegros
changed the title
Namespace for some of the elements of the NRO cannot be known in advance so it is better to read it from the NRO status
jlojosnegros
force-pushed
the
must-gather-test-namespace
branch
from
1121017 to
885b021
Compare
ffromani
reviewed
Aug 11, 2022
| ginkgo.By("Checking 'numaresources' namespace") | ||
| namespaceFolder := filepath.Join(mgContentFolder, "namespaces/numaresources") | ||
| ginkgo.By("Looking for namespace in NUMAResourcesOperator") | ||
| updatedNRO, err := wait.ForDaemonsetInNUMAResourcesOperatorStatus(e2eclient.Client, deployment.NroObj, 5*time.Second, 2*time.Minute) |
There was a problem hiding this comment.
when the NRO status is Available, we should have daemonsets populated (bar unavoidable race). But we can improve later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fromanirh, jlojosnegros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace for some of the elements of the NRO cannot be known in advance
so it is better to read it from the NRO status
correction over: #339
issue: #330
blocks: openshift/release#31102