Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh actions: bump setup-go, fix inconsistent naming #1021

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

ffromani
Copy link
Member

yet another update of github actions which was somehow missed before.
We need a good way to learn the most recent action available.

Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@Tal-or
Copy link
Collaborator

Tal-or commented Sep 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e 723e4f9 link true /test ci-e2e
ci/prow/ci-install-e2e 723e4f9 link true /test ci-install-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Member Author

/retest

we had a mix of .yml and .yaml for no good reason.
Let's standardize on .yaml, as long are gone the times
of 8.3 filenames.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the even-more-gh-actions-bump branch from 723e4f9 to ec2accf Compare September 24, 2024 14:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

New changes are detected. LGTM label has been removed.

fix tool name, got mangled in 39120b8
Why did it start to fail just now?

Signed-off-by: Francesco Romani <[email protected]>
runner images got updated with kind 0.24, so no reason
to get stuck on ancient 1.26.z, upgrade to 1.30.z.
We don't jump to the very last Y stream because we can
use some stability in these lanes.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the even-more-gh-actions-bump branch from 7c568db to 68d8dbf Compare September 24, 2024 14:43
make sure to build catkubeletconfmap

Signed-off-by: Francesco Romani <[email protected]>
add and use wait loop to avoid false negatives in CI

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani merged commit c58a482 into main Sep 24, 2024
10 of 15 checks passed
@ffromani ffromani deleted the even-more-gh-actions-bump branch September 24, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants