Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-14833: E2E: metrics exposed securely #1037

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rbaturov
Copy link
Contributor

@rbaturov rbaturov commented Oct 8, 2024

This is a follow-up PR for #1106 and #1107, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established, for both the manager pod and rte workers.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rbaturov rbaturov force-pushed the promethues-tests branch 6 times, most recently from d0beb3b to 9f47d67 Compare October 9, 2024 07:12
@rbaturov rbaturov changed the title metrics endpoint test for the operator CNF-14833: E2E: metrics exposed securely Oct 9, 2024
@openshift-ci-robot
Copy link

@rbaturov: This pull request references CNF-14833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This is a follow-up PR for #1007 and #1035, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established using kube-rbac-proxy, for both the manager pod and rte workers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@rbaturov: This pull request references CNF-14833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This is a follow-up PR for #1106 and #1107, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established using kube-rbac-proxy, for both the manager pod and rte workers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@rbaturov: This pull request references CNF-14833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This is a follow-up PR for #1106 and #1107, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established, for both the manager pod and rte workers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rbaturov rbaturov force-pushed the promethues-tests branch 6 times, most recently from 7cd8f8f to a36cadf Compare December 26, 2024 10:17
@rbaturov rbaturov marked this pull request as ready for review December 26, 2024 10:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2024
@rbaturov rbaturov force-pushed the promethues-tests branch 2 times, most recently from 5f645bb to 94ed650 Compare December 26, 2024 13:42
@rbaturov
Copy link
Contributor Author

/retest-required

test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2024
@Tal-or
Copy link
Collaborator

Tal-or commented Dec 29, 2024

@rbaturov are those tests running as part of u/s CI?

@rbaturov
Copy link
Contributor Author

@rbaturov are those tests running as part of u/s CI?

Yes, they should as they are part of the serial e2e suite

@Tal-or
Copy link
Collaborator

Tal-or commented Dec 30, 2024

@rbaturov are those tests running as part of u/s CI?

Yes, they should as they are part of the serial e2e suite

The serial suite is not running u/s

don't you prefer these tests will run as part of ci-e2e?

@rbaturov
Copy link
Contributor Author

@rbaturov are those tests running as part of u/s CI?

Yes, they should as they are part of the serial e2e suite

The serial suite is not running u/s

don't you prefer these tests will run as part of ci-e2e?

I'm not sure what the purpose of each of them is. I was just following @ffromani request.
Is the difference that the serial suite includes more intensive and broader coverage?

@rbaturov
Copy link
Contributor Author

rbaturov commented Jan 7, 2025

@ffromani Waiting for your review when you have time

Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor nits, please address and we will merge

test/e2e/serial/tests/metrics.go Show resolved Hide resolved
test/e2e/serial/tests/metrics.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@rbaturov
Copy link
Contributor Author

rbaturov commented Jan 9, 2025

@ffromani This has not been tested in d/s. Maybe we should do a pre-merge test?

Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

yes let's do a pre-merge testing please

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
Added two test to verify that secured metrics fetching can be established, for both the manager pod and RTE workers.

Signed-off-by: Ronny Baturov <[email protected]>
@ffromani
Copy link
Member

ffromani commented Jan 9, 2025

/hold

for pre-merge testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@ffromani
Copy link
Member

ffromani commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@rbaturov
Copy link
Contributor Author

rbaturov commented Jan 9, 2025

/hold

for pre-merge testing

@rshemtov13 will handle this

@rshemtov13
Copy link
Contributor

I've tested both test cases in the d/s CI and both passed

@ffromani
Copy link
Member

ffromani commented Jan 9, 2025

/unhold

ok, thanks! let's move on

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9795e48 into openshift-kni:main Jan 9, 2025
16 checks passed
@rbaturov
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@rbaturov: new pull request created: #1150

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants