-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-14833: E2E: metrics exposed securely #1037
CNF-14833: E2E: metrics exposed securely #1037
Conversation
Skipping CI for Draft Pull Request. |
d0beb3b
to
9f47d67
Compare
@rbaturov: This pull request references CNF-14833 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rbaturov: This pull request references CNF-14833 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rbaturov: This pull request references CNF-14833 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9f47d67
to
d732c1f
Compare
7cd8f8f
to
a36cadf
Compare
5f645bb
to
94ed650
Compare
/retest-required |
94ed650
to
a9039dd
Compare
@rbaturov are those tests running as part of u/s CI? |
Yes, they should as they are part of the serial e2e suite |
The serial suite is not running u/s don't you prefer these tests will run as part of |
I'm not sure what the purpose of each of them is. I was just following @ffromani request. |
@ffromani Waiting for your review when you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some minor nits, please address and we will merge
a19eb92
to
ece7df1
Compare
@ffromani This has not been tested in d/s. Maybe we should do a pre-merge test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
yes let's do a pre-merge testing please
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, rbaturov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added two test to verify that secured metrics fetching can be established, for both the manager pod and RTE workers. Signed-off-by: Ronny Baturov <[email protected]>
ece7df1
to
512f2a2
Compare
/hold for pre-merge testing |
/lgtm |
@rshemtov13 will handle this |
I've tested both test cases in the d/s CI and both passed |
/unhold ok, thanks! let's move on |
/cherry-pick release-4.18 |
@rbaturov: new pull request created: #1150 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a follow-up PR for #1106 and #1107, adding e2e tests to test their functionality.
The tests verify that secured metrics fetching can be established, for both the manager pod and rte workers.