e2e: review CI lanes #1043
Merged
e2e: review CI lanes #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we are (deeply) mutating the cluster state, this was the right thing since the beginning. Signed-off-by: Francesco Romani <[email protected]>
add a bint more description Signed-off-by: Francesco Romani <[email protected]>
The cleanup we do is useless: the CI clusters are deprovisioned all the time, every time, when suites exits (either succesfully or with error). So, let's run the uninstall tests only where really matters: in the install lane, where we care about verifying the cluster state. Signed-off-by: Francesco Romani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this cleanup spawned from #1029.
the idea is to review and streamline what we do in the e2e lanes.
In the main e2e lane the uninstall test(s) don't make much sense, but they make a lot of sense in the (un)install lane.
So let's move code around.
Overall, running wall clock time should not increase, hopefully actually decrease.