api: deprecate v1alpha1

[ffromani]

The API v1alpha1 was not only deprecated before GA, but never advertised. It's time to deprecate. Later we will stop servingf it in 4.18, and remove in 4.19/20.

This change can and should be backported back to 4.16 or perhaps even below

Key references:

• https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation
• https://book.kubebuilder.io/reference/markers/crd
• https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/dependency-resolution.md#deprecateremove-a-version-of-crd

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@ffromani: #1044 failed to apply on top of branch "release-4.17":

Applying: api: deprecate v1alpha1
Using index info to reconstruct a base tree...
M	bundle/manifests/nodetopology.openshift.io_numaresourcesoperators.yaml
M	bundle/manifests/nodetopology.openshift.io_numaresourcesschedulers.yaml
M	bundle/manifests/numaresources-operator.clusterserviceversion.yaml
M	config/crd/bases/nodetopology.openshift.io_numaresourcesoperators.yaml
M	config/crd/bases/nodetopology.openshift.io_numaresourcesschedulers.yaml
Falling back to patching base and 3-way merge...
Auto-merging config/crd/bases/nodetopology.openshift.io_numaresourcesschedulers.yaml
Auto-merging config/crd/bases/nodetopology.openshift.io_numaresourcesoperators.yaml
Auto-merging bundle/manifests/numaresources-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/numaresources-operator.clusterserviceversion.yaml
Auto-merging bundle/manifests/nodetopology.openshift.io_numaresourcesschedulers.yaml
Auto-merging bundle/manifests/nodetopology.openshift.io_numaresourcesoperators.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 api: deprecate v1alpha1

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.