Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] deps: bump deployer dep #1104

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from

Conversation

ffromani
Copy link
Member

consume u/s fixes

consume u/s fixes

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
Copy link
Member Author

/hold

for @Tal-or to review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
cobra is an indirect dependency we pulled since long time ago,
but the linter started to emit warnings about it only recently.

Signed-off-by: Francesco Romani <[email protected]>
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e 2270a1d link true /test ci-e2e
ci/prow/ci-install-e2e 2270a1d link true /test ci-install-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Member Author

@Tal-or lanes are failing with the exact error this PR should solve. But this IIRC should be caused by the very old bug/misconfiguration which causes the lane run with images built against EXISTING codebase (not the patched codebase changed by the PR under test), right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant