e2e: must-gather: fix the setup process #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure we always have a scheduler object reference if both we setup it explicitly or if we skip the setup and just check what the cluster have. Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
|
carrying forward #1115 because holidays |
|
/cc @Tal-or |
Tal-or
reviewed
Dec 16, 2024
make sure the context and timeouts are properly passed down and honored. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
e2e-mg-deployer-fix
branch
from
0f88378 to
82b4e49
Compare
Tal-or
approved these changes
Dec 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.18 |
|
@ffromani: #1120 failed to apply on top of branch "release-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we are skipping the setup, make sure to fetch the existing scheduler data, failing loudly if that resource is not actually present.
Along the way, cleanup the deploy API and package to make sure context and timeout are properly passed down the call chain.