Remove cluster role service RBAC permission leftover #1147
Conversation
* Removed the Service-related RBAC permissions previously granted in the ClusterRole Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
narrow-service-permissions-4.18
branch
from
f792551 to
52be463
Compare
| @@ -62,7 +62,7 @@ metadata: | |||
| } | |||
| ] | |||
| capabilities: Basic Install | |||
| createdAt: "2025-01-07T08:34:09Z" | |||
| createdAt: "2025-01-09T10:45:35Z" | |||
There was a problem hiding this comment.
we need to get rid of this ugly wasteful timestamp
There was a problem hiding this comment.
I could have chosen not to commit this part. I wasn't sure if that was ok since I'm updating this yaml
There was a problem hiding this comment.
every PR does that, yours is not different. We just need to stop updating the timestamp somehow.
There was a problem hiding this comment.
Yes I know. All I'm saying is that we (devs) can choose not to commit that.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, rbaturov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1ef00bc
into
openshift-kni:release-4.18
This PR removes the Service-related RBAC permissions previously granted in the ClusterRole.
This should have been removed as part of the #1140 backport, but it seems to have been unintentionally left behind, likely due to rebase issues.
@ffromani @Tal-or