controller: introduce custom matcher #1149
Conversation
use custom matcher to check reconciliation result. This enable both more concise and more expressive (higher level) code. Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.18 |
|
@ffromani: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
prerequisite for #1124 |
factor out common code which can't fail and which is a minor detail fro the test flow: an ideal candidate for a helper extraction. Signed-off-by: Francesco Romani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ffromani: new pull request created: #1151 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
use custom matcher to check reconciliation result. This enable both more concise and more expressive (higher level) code.