operator: metrics: hooks: add disabling options #723
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ffromani: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ffromani
force-pushed
the
hook-options
branch
from
e50b517 to
6317baf
Compare
main.go
Outdated
| @@ -110,6 +114,8 @@ func main() { | |||
| flag.BoolVar(&showVersion, "version", false, "outputs the version and exit") | |||
| flag.BoolVar(&enableScheduler, "enable-scheduler", false, "enable support for the NUMAResourcesScheduler object") | |||
| flag.BoolVar(&enableWebhooks, "enable-webhooks", false, "enable conversion webhooks") | |||
| flag.BoolVar(&enableWebhooks, "enable-metrics", false, "enable metrics server") | |||
There was a problem hiding this comment.
you already have a flag (metricsAddr), wouldn't it be better to change the default value? Otherwise the cli ux is misleading, you set the address but nothing happens
There was a problem hiding this comment.
Yes, I'm still evaluating the best approach here
add command line flags and options to disable the functionality, and disable it by default. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
hook-options
branch
from
6317baf to
1e865a1
Compare
|
/cherry-pick release-4.14 |
|
@ffromani: new pull request created: #724 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ffromani
added
the
cherry-pick-approved
add command line flags and options to disable
the functionality, and disable it by default.