Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rte: add toggle to disable prometheus #726

Closed
wants to merge 1 commit into from
Closed

rte: add toggle to disable prometheus #726

wants to merge 1 commit into from

Conversation

ffromani
Copy link
Member

make it configurable

@ffromani
Copy link
Member Author

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from swatisehgal and Tal-or October 19, 2023 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@ffromani ffromani added cherry-pick-candidate Possible cherry-pick in the future and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2023
@ffromani
rte: add toggle to disable prometheus
02c385f 
make it configurable

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e 02c385f link true /test ci-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani
Copy link
Member Author

obsoleted by #727

@ffromani ffromani closed this Oct 20, 2023
@ffromani ffromani deleted the rte-toggle-prom branch October 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@Tal-or Tal-or Awaiting requested review from Tal-or

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-candidate Possible cherry-pick in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffromani @openshift-cherrypick-robot