Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing the event title matching issue #1525

Merged

Conversation

savitaashture
Copy link
Member

When event_title.startsWith() is used
for pull_request, the CEL expressions
do not behave as anticipated due to the
lack of handling for pull_request events.

Signed-off-by: Savita Ashture [email protected]

Changes

Submitter Checklist

  • 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
  • ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
  • ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a00add) 62.93% compared to head (fdb1f7c) 62.92%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   62.93%   62.92%   -0.02%     
==========================================
  Files         130      130              
  Lines       10420    10421       +1     
==========================================
- Hits         6558     6557       -1     
- Misses       3342     3344       +2     
  Partials      520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When event_title.startsWith() is used
for pull_request, the CEL expressions
do not behave as anticipated due to the
lack of handling for pull_request events.

Signed-off-by: Savita Ashture <[email protected]>
@piyush-garg
Copy link
Member

lgtm

We don't need to do for other providers?

@savitaashture
Copy link
Member Author

lgtm

We don't need to do for other providers?

Its handled for other providers but for Github It missed somehow

@chmouel
Copy link
Member

chmouel commented Dec 8, 2023

@savitaashture @piyush-garg did you test this manually?

@chmouel chmouel merged commit 3053676 into openshift-pipelines:main Dec 8, 2023
@savitaashture
Copy link
Member Author

@savitaashture @piyush-garg did you test this manually?

Yes i have tested manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants