Add -O option to not reinstall kind #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
force-pushed
the
add--o-option-to-not-reinstall-kind
branch
from
81fe777 to
132ceb4
Compare
I have kind timing out on high load on my laptops, so i need to restart the reinstall process without having to redo the whole install again, so adding the -O option to shortcut thing a bit. Signed-off-by: Chmouel Boudjnah <[email protected]>
It was not tested explicitly so let's add a test for it. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
add--o-option-to-not-reinstall-kind
branch
from
c4da849 to
dbe8e43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
+ Coverage 63.14% 63.18% +0.03%
==========================================
Files 132 132
Lines 10606 10606
==========================================
+ Hits 6697 6701 +4
+ Misses 3380 3378 -2
+ Partials 529 527 -2 ☔ View full report in Codecov by Sentry. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have kind timing out on high load on my laptops, so i need to restart the reinstall process without having to redo the whole install again, so adding the -O option to shortcut thing a bit.
Reformat the script with shfmt as well
Add a unit test for applyStandardFormat to get the golang test started
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).