Implement GetFiles Func of Bitbucket Server Provider for CEL Expression #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
reviewed
Feb 6, 2025
| // `response.Page.Last` is set to `0`. Therefore, to determine if there are more items to fetch, | ||
| // we can check if the length of the currently fetched items is less than the specified limit. | ||
| // If the length is less than the limit, it indicates that there are no more items to retrieve. | ||
| if len(changes) < limit { |
There was a problem hiding this comment.
for example there are 101 changes for PR and limit is 100 so on first iteration we will get 100 changes so if we do it len(changes) <= limit it will break loop and we'll miss left "one" change.
There was a problem hiding this comment.
if changes is equal to limit there might be more items.
implemented GetFiles func of Bitbucket server which lists changed files on an event. it also solves the issue in Bitbucket server where pathChanged() function in CEL expression was not working because the func was not implemented. this does slove the issue. https://issues.redhat.com/browse/SRVKP-5834 Signed-off-by: Zaki Shaikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented GetFiles func of Bitbucket server which lists changed files on an event. it also solves the issue in Bitbucket server where pathChanged() function in CEL expression was not working because the func was not implemented. this does slove the issue.
upstream issue: #1738
https://issues.redhat.com/browse/SRVKP-5834
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the documentation accordingly)