NO-ISSUE: Add cluster name to OCI bucket name #2605
Conversation
…rm output to the generated bucket.
|
@eliorerz: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: talhil-rh. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
openshift-ci
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| self._upload_data_to_bucket( | ||
| terraform_output, f"terraform-output-{self._entity_config.cluster_id}.yaml", namespace, bucket_name | ||
| ) |
There was a problem hiding this comment.
why? the bucket will be cleaned up after the test.
The terraform output is available in the OCI stack, so it's can be extracted from there directly using the API.
There was a problem hiding this comment.
QE in some cases are deploying the nodes and leave all the resources up
There was a problem hiding this comment.
We would like to use it with Cypress flow. In this case, we need the ability to read the yaml from outside test-infra.
/cc @dudyas6
There was a problem hiding this comment.
About the resource that not cleanup: we store a stack for it and it must run at the reverse order .
In case we abort test-infra . it would stay there.
in othercase i have a bug with cleanup , did we try this flow on OCI ?
| namespace, | ||
| bucket_name, | ||
| self._config.oci_infrastructure_zip_file, | ||
| terraform_variables, | ||
| ) | ||
| terraform_output = self._apply_job_from_stack(stack_id, random_name("job-")) |
There was a problem hiding this comment.
| terraform_output = self._apply_job_from_stack(stack_id, random_name("job-")) | |
| terraform_output = self._apply_job_from_stack(stack_id, "create-infra") |
as we applied it only once, it should be enough.
There was a problem hiding this comment.
For my understanding QE has sometimes more then one job per cluster, that is why left it as it is.
@talhil-rh @dudyas6 Can you reffer to that?
There was a problem hiding this comment.
the job is attached to the stack where the cluster infra is defined /cc @bkopilov
eliorerz
changed the title
/cc @talhil-rh