-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTIARCH-5289: download_iso fix issue when downloading iso for s390x #2615
MULTIARCH-5289: download_iso fix issue when downloading iso for s390x #2615
Conversation
Signed-off-by: Amadeus Podvratnik <[email protected]>
Hi @AmadeusPodvratnik. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle MULTIARCH-5289: download_iso fix issue when downloading iso for s390x |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, AmadeusPodvratnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AmadeusPodvratnik: This pull request references MULTIARCH-5289 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aca3600
into
openshift:master
@AmadeusPodvratnik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fix following error:
if platform == consts.CPUArchitecture.S390X:
E TypeError: Can't instantiate abstract class ZVMController without an implementation for abstract methods 'destroy_network', 'get_cluster_network', 'set_per_device_boot_order'
when running download_iso test case.