Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-5289: download_iso fix issue when downloading iso for s390x #2615

Conversation

AmadeusPodvratnik
Copy link
Contributor

Fix following error:
if platform == consts.CPUArchitecture.S390X:

      return ZVMController(controller_configuration, cluster_configuration)

E TypeError: Can't instantiate abstract class ZVMController without an implementation for abstract methods 'destroy_network', 'get_cluster_network', 'set_per_device_boot_order'

when running download_iso test case.

@openshift-ci openshift-ci bot requested review from danmanor and omertuc January 15, 2025 17:22
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2025
Copy link

openshift-ci bot commented Jan 15, 2025

Hi @AmadeusPodvratnik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adriengentil
Copy link
Contributor

adriengentil commented Jan 16, 2025

/retitle MULTIARCH-5289: download_iso fix issue when downloading iso for s390x

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@openshift-ci openshift-ci bot changed the title MULTIARCH-5289_download_iso fix issue when downloading iso for s390x. MULTIARCH-5289: download_iso fix issue when downloading iso for s390x Jan 16, 2025
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, AmadeusPodvratnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025

@AmadeusPodvratnik: This pull request references MULTIARCH-5289 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Fix following error:
if platform == consts.CPUArchitecture.S390X:

      return ZVMController(controller_configuration, cluster_configuration)

E TypeError: Can't instantiate abstract class ZVMController without an implementation for abstract methods 'destroy_network', 'get_cluster_network', 'set_per_device_boot_order'

when running download_iso test case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit aca3600 into openshift:master Jan 16, 2025
10 of 12 checks passed
Copy link

openshift-ci bot commented Jan 16, 2025

@AmadeusPodvratnik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-none-4-18 377fea8 link false /test e2e-metal-assisted-none-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants