Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Correct wording in SDN documentation #5350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saintdle
Copy link

@saintdle saintdle commented Jan 7, 2025

What this PR does / why we need it:

Fixes wording in the SDN document as it doesn't read correctly.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # n/a

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

Hi @saintdle. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor

jparrill commented Jan 9, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2025
@jparrill
Copy link
Contributor

jparrill commented Jan 9, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, saintdle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@jparrill
Copy link
Contributor

jparrill commented Jan 9, 2025

/retest

@saintdle
Copy link
Author

@jparrill do the other two tests need triggering or can this be merged as is?

@bryan-cox
Copy link
Member

Could you update the commit to be in the imperative tone per 6. here - https://hypershift.pages.dev/contribute/#prior-to-submitting-a-pull-request?

@saintdle saintdle changed the title wording fix - other-sdn-providers.md Correct wording in documentation Jan 15, 2025
@saintdle saintdle changed the title Correct wording in documentation Correct wording in SDN documentation Jan 15, 2025
@saintdle
Copy link
Author

Could you update the commit to be in the imperative tone per 6. here - https://hypershift.pages.dev/contribute/#prior-to-submitting-a-pull-request?

Done

@bryan-cox
Copy link
Member

Thanks!

/retitle NO-JIRA: Correct wording in SDN documentation
/lgtm

@openshift-ci openshift-ci bot changed the title Correct wording in SDN documentation NO-JIRA: Correct wording in SDN documentation Jan 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2025
@openshift-ci-robot
Copy link

@saintdle: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

Fixes wording in the SDN document as it doesn't read correctly.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # n/a

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@saintdle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants