Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the direct MCO dependency #251

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Jan 22, 2025

This dependency has been replaced by the OpenShift APIs package.

@openshift-ci openshift-ci bot requested review from bitoku and cblecker January 22, 2025 00:04
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkowl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@hawkowl
Copy link
Contributor Author

hawkowl commented Jan 22, 2025

Actually, this'll need to happen in 4.16?

@hawkowl hawkowl force-pushed the hawkowl/remove-mco-dep branch from ff3ca5f to 75d4e96 Compare February 5, 2025 22:54
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@hawkowl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 75d4e96 link true /test images
ci/prow/lint 75d4e96 link true /test lint
ci/prow/validate 75d4e96 link true /test validate
ci/prow/unit 75d4e96 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant