-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Support installation on SEV SNP confidential nodes #9395
base: main
Are you sure you want to change the base?
Conversation
Hi @bgartzi. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abf4942
to
ca991db
Compare
+ mod tidy + mod vendor
This will let choose sev or sev-snp as the confidential computing technology of choice. The way it behaves together with confidentialCompute is due to 2 reasons: - Backwards compatibility. - Mimicing the wave the GCP API behaves.
I created the infrastructure-components of CAPG myself and added it here for proof of concept purposes. I needed the local CAPI to be able to manage the confidentialInstanceType argument. The file was built out of [0]. [0] openshift/cluster-api-provider-gcp#235
This patch series aims to support installing a cluster on AMD SEV SNP confidential nodes.
Previously, only AMD SEV nodes were supported, which were configured through the
confidentialCompute
configuration flag.Now that GCP supports specifying the confidential instance type, we are letting users specify which node type (SEV/SEV-SNP) they would like to deploy the cluster on.
This series depend on the following patches:
kubernetes-sigs/cluster-api-provider-gcp#1410
openshift/api#2165
openshift/machine-api-operator#1324
openshift/machine-api-provider-gcp#107
I will update the
go.mod
replace sections pointing to personal forks once they are accepted.