Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-26790 continue upgrade despite notif failure #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tafhim
Copy link

@Tafhim Tafhim commented Jan 17, 2025

What type of PR is this?

bug

What this PR does / why we need it?

Fixes MUO upgrade completion blocked by SL failure.

Which Jira/Github issue(s) this PR fixes?

OSD-26790

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Included documentation changes with PR

…notify, update unit test to reflect the change
…ing to notify, update unit test to reflect the change
@openshift-ci openshift-ci bot requested review from bmeng and tkong-redhat January 17, 2025 10:49
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tafhim
Once this PR has been reviewed and has the lgtm label, please assign abyrne55 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@Tafhim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.22%. Comparing base (cb3ae47) to head (af6af79).

Files with missing lines Patch % Lines
pkg/upgraders/controlplanestep.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         122      122           
  Lines        5953     5953           
=======================================
  Hits         3228     3228           
  Misses       2523     2523           
  Partials      202      202           
Files with missing lines Coverage Δ
pkg/upgraders/controlplanestep.go 95.00% <66.66%> (ø)

@ravitri
Copy link
Member

ravitri commented Jan 17, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants