-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump kubernetes-container-terminal to v3.0.0 #2849
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
rhamilto:container-terminal-next
Mar 1, 2018
Merged
Bump kubernetes-container-terminal to v3.0.0 #2849
openshift-merge-robot
merged 1 commit into
openshift:master
from
rhamilto:container-terminal-next
Mar 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Feb 23, 2018
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Feb 23, 2018
This was referenced Feb 27, 2018
rhamilto
changed the title
[WIP] Bump kubernetes-container-terminal to v3.0.0
Bump kubernetes-container-terminal to v3.0.0
Mar 1, 2018
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Mar 1, 2018
spadgett
approved these changes
Mar 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 1, 2018
@rhamilto Looks like you need to rebase on your other change that merged. |
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires kubernetes-ui/container-terminal#35
Known issues: