Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-container-terminal to v3.0.0 #2849

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Bump kubernetes-container-terminal to v3.0.0 #2849

merged 1 commit into from
Mar 1, 2018

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Feb 23, 2018

Requires kubernetes-ui/container-terminal#35

screen shot 2018-02-23 at 10 37 13 am
screen shot 2018-02-23 at 10 37 38 am

Known issues:

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 23, 2018
@rhamilto rhamilto added this to the 3.10.0 milestone Feb 23, 2018
@spadgett
Copy link
Member

/hold
for 3.10

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2018
@rhamilto rhamilto changed the title [WIP] Bump kubernetes-container-terminal to v3.0.0 Bump kubernetes-container-terminal to v3.0.0 Mar 1, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2018
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2018
@spadgett
Copy link
Member

spadgett commented Mar 1, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2018
@spadgett
Copy link
Member

spadgett commented Mar 1, 2018

@rhamilto Looks like you need to rebase on your other change that merged.

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2018
@spadgett
Copy link
Member

spadgett commented Mar 1, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 9ba9a99 into openshift:master Mar 1, 2018
@rhamilto rhamilto deleted the container-terminal-next branch March 1, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants