Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Add irqbalance to aarch64 builds #1602

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

bartwensley
Copy link
Contributor

The irqbalance package is required for low latency applications. It is present in the x86_64 RHCOS build, but not the aarch64 build. It is already included in the aarch64 build of Fedora CoreOS so this is just bringing RHCOS up to date.
closes #1601

The irqbalance package is required for low latency applications.
It is present in the x86_64 RHCOS build, but not the aarch64 build.
It is already included in the aarch64 build of Fedora CoreOS so
this is just bringing RHCOS up to date.

Signed-off-by: Bart Wensley <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2024
@openshift-ci-robot
Copy link

@bartwensley: This pull request explicitly references no jira issue.

In response to this:

The irqbalance package is required for low latency applications. It is present in the x86_64 RHCOS build, but not the aarch64 build. It is already included in the aarch64 build of Fedora CoreOS so this is just bringing RHCOS up to date.
closes #1601

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bartwensley
Copy link
Contributor Author

/retest

@bartwensley
Copy link
Contributor Author

/cc @jlebon

@openshift-ci openshift-ci bot requested a review from jlebon September 5, 2024 12:06
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

@bartwensley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Sep 5, 2024

Is there a Jira ticket associated with this? How did you notice this?

@bartwensley
Copy link
Contributor Author

Is there a Jira ticket associated with this?

There is no Jira but I raised issue #1602

How did you notice this?

I am doing latency testing on an ARM server and the results were terrible without irqbalance.

@jlebon
Copy link
Member

jlebon commented Sep 5, 2024

/approve
/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartwensley, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7904729 into openshift:master Sep 5, 2024
7 checks passed
@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/cherry-pick release-4.16

@openshift-cherrypick-robot

@c4rt0: new pull request created: #1728

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/cherry-pick release-4.17

@openshift-cherrypick-robot

@c4rt0: new pull request created: #1729

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/jira backport release-4.17 release-4.16

@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/jira backport release-4.17,release-4.16

@openshift-ci-robot
Copy link

@c4rt0: Missing required branches for backport chain:

  • release-4.18 OR openshift-4.18,

In response to this:

/jira backport release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/jira backport release-4.18,release-4.17,release-4.16

@openshift-ci-robot
Copy link

@c4rt0: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16

In response to this:

/jira backport release-4.18,release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request could not be created: failed to create pull request against openshift/os#release-4.16 from head openshift-cherrypick-robot:cherry-pick-1602-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-1602-to-release-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

@c4rt0: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16

In response to this:

/jira backport release-4.18,release-4.17,release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Jan 30, 2025

/jira backport release-4.18

@openshift-ci-robot
Copy link

@c4rt0: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request could not be created: failed to create pull request against openshift/os#release-4.18 from head openshift-cherrypick-robot:cherry-pick-1602-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.18 and openshift-cherrypick-robot:cherry-pick-1602-to-release-4.18"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

@c4rt0: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add irqbalance to aarch64 builds of RHCOS
5 participants