Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new extension qemu-kiwi #497

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Add new extension qemu-kiwi #497

merged 1 commit into from
Mar 1, 2021

Conversation

jensfr
Copy link
Contributor

@jensfr jensfr commented Feb 5, 2021

This adds qemu-kiwi as another extension to the list.
The qemu-kiwi extension is added to MCO with this PR openshift/machine-config-operator#2376
qemu-kiwi is a shrunk-down version of the qemu-kvm package with fewer dependencies. 8 rpms and ~20MB in size when installed

@cgwalters
Copy link
Member

It looks like openshift/enhancements#366 was closed - if we're going to do this, let's at least get the enhancement re-opened, polished and merged.
Overall
/approve
the idea,
/hold
for the enhancement.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2021
@miabbott
Copy link
Member

It looks like openshift/enhancements#366 was closed - if we're going to do this, let's at least get the enhancement re-opened, polished and merged.
Overall
/approve
the idea,
/hold
for the enhancement.

The enhancement has been getting some additional polish and review, so I'm in favor of dropping the /hold on this and get the changes merged in to unblock the rest of the effort. (This wouldn't be the first time we merged changes without the enhancement being committed)

@jlebon
Copy link
Member

jlebon commented Feb 23, 2021

This would be a good one to rebase on top of #496. It should also allow you to simplify the list by dropping deps (which will now get automatically pulled in).

@cgwalters
Copy link
Member

Agree let's land the extensions rework before we pile on more extensions.

@miabbott
Copy link
Member

With #496 landed, I started poking at this and found that we need to include a new repo for RHEL-AV

Will require some coordination getting the OCP to get those RPM mirrored - https://github.com/openshift/release/blob/master/core-services/release-controller/README.md#rpm-mirrors

And a repo configured on the internal redhat-coreos repo

@miabbott
Copy link
Member

Needs openshift/release#16258

@miabbott
Copy link
Member

@jensfr I rebased this and pushed an additional commit to your branch; may want to squash them

@jensfr
Add new extension qemu-kiwi
af93514 
This adds qemu-kiwi as another extension to the list. qemu-kiwi and its
dependencies are in the rhel-8-advanced-virt repository, so we have to
add this as well.

The qemu-kiwi extension is added to MCO with this PR
openshift/machine-config-operator#2376

qemu-kiwi is a shrunk-down version of the qemu-kvm package with fewer
dependencies. 8 rpms and ~20MB in size when installed
@jensfr
Copy link
Contributor Author

jensfr commented Feb 25, 2021

Thank you @miabbott ! I squashed the two commits

@miabbott
Copy link
Member

Since the CI is broken (#506), I did some light testing manually with a properly configured rhel-8-advanced-virt repo file:

$ cosa buildextend-extensions
...
$ $ jq .extensions < builds/latest/x86_64/meta.json 
{
  "path": "rhcos-48.83.202102251842-0-extensions.x86_64.tar",
  "sha256": "446e3b4d3024fca331cd093f001f3ef503638a88c1854b3dadc2bf8208550b28",
  "rpm-ostree-state": "2837a50711b1bf0de265ba7e638bb9f8fd9c619807fadac86b82eb5168d16387e6cb14026a46fd79e93b64772aa609cbe40211d86bee26ebbfe6e5c859cb0635",
  "manifest": {
    "ipxe-roms-qemu": "20181214-6.git133f4c47.el8.noarch",
    "kernel": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-core": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-devel": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-headers": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-modules": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-modules-extra": "4.18.0-240.15.1.el8_3.x86_64",
    "kernel-rt-core": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
    "kernel-rt-devel": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
    "kernel-rt-kvm": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
    "kernel-rt-modules": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
    "kernel-rt-modules-extra": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
    "libpmem": "1.6.1-1.el8.x86_64",
    "libqb": "1.0.3-12.el8.x86_64",
    "pixman": "0.38.4-1.el8.x86_64",
    "protobuf": "3.5.0-13.el8.x86_64",
    "qemu-kiwi": "15:5.1.0-20.module+el8.3.1+9918+230f5c26.x86_64",
    "qemu-kvm-common": "15:5.1.0-20.module+el8.3.1+9918+230f5c26.x86_64",
    "seabios-bin": "1.14.0-1.module+el8.3.0+7638+07cf13d2.noarch",
    "seavgabios-bin": "1.14.0-1.module+el8.3.0+7638+07cf13d2.noarch",
    "sgabios-bin": "1:0.20170427git-3.module+el8.3.0+6124+819ee737.noarch",
    "usbguard": "0.7.8-7.el8.x86_64",
    "usbguard-selinux": "0.7.8-7.el8.noarch"
  }
}

/override ci/prow/unit

@openshift-ci-robot
Copy link

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/unit

In response to this:

Since the CI is broken (#506), I did some light testing manually with a properly configured rhel-8-advanced-virt repo file:

$ cosa buildextend-extensions
...
$ $ jq .extensions < builds/latest/x86_64/meta.json 
{
 "path": "rhcos-48.83.202102251842-0-extensions.x86_64.tar",
 "sha256": "446e3b4d3024fca331cd093f001f3ef503638a88c1854b3dadc2bf8208550b28",
 "rpm-ostree-state": "2837a50711b1bf0de265ba7e638bb9f8fd9c619807fadac86b82eb5168d16387e6cb14026a46fd79e93b64772aa609cbe40211d86bee26ebbfe6e5c859cb0635",
 "manifest": {
   "ipxe-roms-qemu": "20181214-6.git133f4c47.el8.noarch",
   "kernel": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-core": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-devel": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-headers": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-modules": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-modules-extra": "4.18.0-240.15.1.el8_3.x86_64",
   "kernel-rt-core": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
   "kernel-rt-devel": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
   "kernel-rt-kvm": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
   "kernel-rt-modules": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
   "kernel-rt-modules-extra": "4.18.0-240.15.1.rt7.69.el8_3.x86_64",
   "libpmem": "1.6.1-1.el8.x86_64",
   "libqb": "1.0.3-12.el8.x86_64",
   "pixman": "0.38.4-1.el8.x86_64",
   "protobuf": "3.5.0-13.el8.x86_64",
   "qemu-kiwi": "15:5.1.0-20.module+el8.3.1+9918+230f5c26.x86_64",
   "qemu-kvm-common": "15:5.1.0-20.module+el8.3.1+9918+230f5c26.x86_64",
   "seabios-bin": "1.14.0-1.module+el8.3.0+7638+07cf13d2.noarch",
   "seavgabios-bin": "1.14.0-1.module+el8.3.0+7638+07cf13d2.noarch",
   "sgabios-bin": "1:0.20170427git-3.module+el8.3.0+6124+819ee737.noarch",
   "usbguard": "0.7.8-7.el8.x86_64",
   "usbguard-selinux": "0.7.8-7.el8.noarch"
 }
}

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott miabbott requested review from jlebon and cgwalters and removed request for ashcrow and mike-nguyen February 26, 2021 15:05
@jlebon
Copy link
Member

jlebon commented Mar 1, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jensfr, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miabbott
Copy link
Member

miabbott commented Mar 1, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member

miabbott commented Mar 1, 2021

/override prow/ci/unit

Still builds fine locally; CI is known to be down for our tests

@openshift-ci-robot
Copy link

@miabbott: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • prow/ci/unit

Only the following contexts were expected:

  • ci/prow/unit
  • tide

In response to this:

/override prow/ci/unit

Still builds fine locally; CI is known to be down for our tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member

miabbott commented Mar 1, 2021

/override ci/prow/unit

sigh

@openshift-ci-robot
Copy link

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/unit

In response to this:

/override ci/prow/unit

sigh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 04a048c into openshift:master Mar 1, 2021
@miabbott miabbott mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@jlebon jlebon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jensfr @cgwalters @miabbott @jlebon @openshift-ci-robot @openshift-bot @openshift-merge-robot