Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stackrox: add new ci images to image mirror #55779

Merged
merged 1 commit into from
Aug 21, 2024
Merged

stackrox: add new ci images to image mirror #55779

merged 1 commit into from
Aug 21, 2024

Conversation

BradLugo
Copy link
Contributor

Description

Adds stackrox/apollo-ci:stackrox-test-0.4.2 and stackrox/apollo-ci:stackrox-ui-test-0.4.2 to the OSCI image mirror. This will make testing easier testing for #55687.

fwiw, I plan to remove the older images from the mirror after #55687 is merged

/cc @davdhacs @tommartensen @janisz

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 20, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@BradLugo BradLugo force-pushed the blugo/add-new-stackrox-ci-image branch from b766ddf to 94261bb Compare August 20, 2024 16:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2024
@BradLugo BradLugo force-pushed the blugo/add-new-stackrox-ci-image branch from 94261bb to 4683fbe Compare August 20, 2024 16:33
davdhacs
davdhacs reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@davdhacs davdhacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
nit, can the _config.yaml change be removed?

core-services/ci-secret-bootstrap/_config.yaml Outdated
@@ -5839,7 +5839,7 @@ secret_configs:
registry_url: quay-proxy.ci.openshift.org
- auth_field: auth
item: quayio-ci-read-only-robot
registry_url: quay.io/openshift/
registry_url: quay.io/openshift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be removed? I don't know what this could affect.

Copy link
Contributor Author

@BradLugo BradLugo Aug 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a result of make update-ci-build-clusters, which CI indicated was required: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/55779/pull-ci-openshift-release-master-build-clusters/1825934199392047104

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thank you

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@BradLugo
Copy link
Contributor Author

/retest-required

@BradLugo
Copy link
Contributor Author

/cc @hongkailiu
/assign @hongkailiu

@openshift-ci openshift-ci bot requested a review from hongkailiu August 20, 2024 18:58
@BradLugo BradLugo force-pushed the blugo/add-new-stackrox-ci-image branch from 18f67cf to 23db6c6 Compare August 21, 2024 17:40
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@BradLugo: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024 •
edited
Loading

@BradLugo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/build-farm/vsphere02-dry b766ddf link true /test vsphere02-dry
ci/build-farm/hosted-mgmt-dry b766ddf link true /test hosted-mgmt-dry
ci/build-farm/build01-dry b766ddf link true /test build01-dry
ci/build-farm/app-ci-config-dry b766ddf link true /test app-ci-config-dry
ci/build-farm/build10-dry b766ddf link true /test build10-dry
ci/build-farm/build03-dry b766ddf link true /test build03-dry
ci/build-farm/build09-dry b766ddf link true /test build09-dry
ci/build-farm/build05-dry b766ddf link true /test build05-dry
ci/build-farm/build02-dry b766ddf link true /test build02-dry
ci/build-farm/build04-dry b766ddf link true /test build04-dry
ci/prow/sync-rover-groups b766ddf link true /test sync-rover-groups
ci/build-farm/build11-dry b766ddf link true /test build11-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Contributor

/retest

@deepsm007
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradLugo, davdhacs, deepsm007, janisz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3e57dea into openshift:master Aug 21, 2024
8 checks passed
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
@BradLugo @MiguelCarpio
stackrox: add new ci images to image mirror (openshift#55779)
85d8a26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davdhacs davdhacs davdhacs left review comments

@janisz janisz janisz approved these changes

@tommartensen tommartensen Awaiting requested review from tommartensen

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@janisz janisz

@hongkailiu hongkailiu

@deepsm007 deepsm007

@davdhacs davdhacs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BradLugo @openshift-ci-robot @deepsm007 @janisz @davdhacs @hongkailiu @openshift-merge-robot