Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kni: nrop: kickoff 4.19 branch #59948

Merged

Conversation

ffromani
Copy link
Contributor

Main is now pointing to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files.

Alternative to #59761

Main is now poiting to 4.19, and release-4.18 was branched so update the
configuration for main and create 4.18 relevant files.

Co-Authored-By: Francesco Romani <[email protected]>
Signed-off-by: Shereen Haj <[email protected]>
@ffromani
Copy link
Contributor Author

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-ci openshift-ci bot requested review from shajmakh and Tal-or December 17, 2024 08:01
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ffromani: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e-install-hypershift openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-index-tested-numaresources-operator-bundle openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-install-e2e openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-unit openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-images openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-release-4.18-security openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e-install-hypershift openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-index-tested-numaresources-operator-bundle openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-install-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-unit openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-images openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-security openshift-kni/numaresources-operator presubmit Ci-operator config changed
periodic-ci-openshift-kni-numaresources-operator-release-4.18-ci-must-gather-e2e N/A periodic Periodic changed
periodic-ci-openshift-kni-numaresources-operator-main-ci-must-gather-e2e N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ffromani
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@ffromani: job(s): periodic-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e either don't exist or were not found to be affected, and cannot be rehearsed

@ffromani
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ffromani
Copy link
Contributor Author

/cc @Tal-or

@ffromani
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 17, 2024
@@ -1,8 +1,10 @@
# numaresources-operator
registry.ci.openshift.org/ocp-kni/numaresources-operator:numaresources-operator-tests quay.io/openshift-kni/numaresources-operator-tests:4.18.999-snapshot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are moving them to 4.19, we keep publishing the bundles. I guess I can reorder the lines to make it easier to read the diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on second look the ordering seems good:

  • tests (only from main)
  • bundle (main, then releases from newest to oldest)
  • operator (main, then releases from newest to oldest)
  • rte (CI only)
  • must-gather (CI only)

@Tal-or
Copy link
Contributor

Tal-or commented Dec 17, 2024

/hold
/lgtm
/pj-rehearse ack

If #59948 (comment) irrelevant please unhold

@openshift-ci-robot
Copy link
Contributor

@Tal-or: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@ffromani
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@shajmakh
Copy link
Contributor

/lgtm
Thanks a lot for handling it!

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 78aa201 into openshift:master Dec 18, 2024
31 checks passed
@ffromani ffromani deleted the kni-nrop-4.19-updates-take2 branch December 18, 2024 08:14
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@ffromani: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_openshift-kni_quay using file core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay

In response to this:

Main is now pointing to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files.

Alternative to #59761

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
Main is now poiting to 4.19, and release-4.18 was branched so update the
configuration for main and create 4.18 relevant files.

Signed-off-by: Shereen Haj <[email protected]>
Co-authored-by: Shereen Haj <[email protected]>
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
Main is now poiting to 4.19, and release-4.18 was branched so update the
configuration for main and create 4.18 relevant files.

Signed-off-by: Shereen Haj <[email protected]>
Co-authored-by: Shereen Haj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants