-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kni: nrop: kickoff 4.19 branch #59948
kni: nrop: kickoff 4.19 branch #59948
Conversation
Main is now poiting to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files. Co-Authored-By: Francesco Romani <[email protected]> Signed-off-by: Shereen Haj <[email protected]>
/pj-rehearse max |
@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse periodic-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e |
@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@ffromani: job(s): periodic-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e either don't exist or were not found to be affected, and cannot be rehearsed |
/pj-rehearse pull-ci-openshift-kni-numaresources-operator-release-4.18-ci-e2e |
@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/cc @Tal-or |
/pj-rehearse ack |
@ffromani: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@@ -1,8 +1,10 @@ | |||
# numaresources-operator | |||
registry.ci.openshift.org/ocp-kni/numaresources-operator:numaresources-operator-tests quay.io/openshift-kni/numaresources-operator-tests:4.18.999-snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we dropping this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are moving them to 4.19, we keep publishing the bundles. I guess I can reorder the lines to make it easier to read the diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on second look the ordering seems good:
- tests (only from main)
- bundle (main, then releases from newest to oldest)
- operator (main, then releases from newest to oldest)
- rte (CI only)
- must-gather (CI only)
/hold If #59948 (comment) irrelevant please unhold |
@Tal-or: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, shajmakh, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ffromani: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Main is now poiting to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files. Signed-off-by: Shereen Haj <[email protected]> Co-authored-by: Shereen Haj <[email protected]>
Main is now poiting to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files. Signed-off-by: Shereen Haj <[email protected]> Co-authored-by: Shereen Haj <[email protected]>
Main is now pointing to 4.19, and release-4.18 was branched so update the configuration for main and create 4.18 relevant files.
Alternative to #59761