Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-8332 | test: automated id:68751 #2115

Merged
merged 1 commit into from
May 30, 2024
Merged

OCM-8332 | test: automated id:68751 #2115

merged 1 commit into from
May 30, 2024

Conversation

yingzhanredhat
Copy link
Contributor 

[yingzhan@localhost rosa]$ ginkgo -focus 68751 tests/e2e/

Running Suite: e2e tests suite - /home/yingzhan/autotest/rosa/tests/e2e
=======================================================================
Random Seed: 1717061657

Will run 1 of 92 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 1 of 92 Specs in 25.090 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 91 Skipped
PASS

Ginkgo ran 1 suite in 27.801842499s
Test Suite Passed

@openshift-ci openshift-ci bot requested review from yasun1 and yuwang-RH May 30, 2024 09:59
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.65%. Comparing base (4fc1b8f) to head (c7889bb).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2115   +/-   ##
=======================================
  Coverage   26.65%   26.65%           
=======================================
  Files         152      152           
  Lines       21407    21407           
=======================================
  Hits         5707     5707           
  Misses      15275    15275           
  Partials      425      425

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yasun1
yasun1 reviewed May 30, 2024
View reviewed changes
tests/e2e/test_rosacli_network_verifier.go Outdated
@@ -143,4 +143,59 @@ var _ = Describe("Network verifier",
Expect(err).ToNot(HaveOccurred())
})

// The network verifier validation should work well
It("The network verifier validation should work well - [id:68751]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec title should be validation should work well

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

@yingzhanredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yasun1
Copy link
Contributor

yasun1 commented May 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yasun1, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b39dd0 into openshift:master May 30, 2024
11 checks passed
@yingzhanredhat yingzhanredhat deleted the ying-test branch October 14, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasun1 yasun1 yasun1 left review comments

@yuwang-RH yuwang-RH Awaiting requested review from yuwang-RH

Assignees

@yasun1 yasun1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yingzhanredhat @yasun1