Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-4969 | feat: offline token deprecation messaging #2554

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylercreller
Copy link
Member

  • Adds deprecation messaging when using offline tokens every time tokens are changed/recycled

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tylercreller
Once this PR has been reviewed and has the lgtm label, please assign gdbranco for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tylercreller tylercreller marked this pull request as draft October 17, 2024 18:59
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@tylercreller
Copy link
Member Author

Marking as a draft, requires sign-off from product management.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2025
@lnagendr
Copy link

lnagendr commented Feb 11, 2025

This would be the suggested messaging on the CLI

For ROSA: Logging in with offline tokens is being deprecated. For enhanced security, we recommend authenticating your SSO credentials by logging in with --use-auth-code or --use-device-code. See 'rosa login --help' for usage. Learn more about deprecating offline tokens via https://console.redhat.com/openshift/token/rosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants