Simplify glance-operator pvc interface #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konan-abhi
reviewed
Jun 11, 2024
fmount
force-pushed
the
simple_pvc_interface
branch
from
345d5ce to
c6ef503
Compare
fmount
changed the title
fmount
force-pushed
the
simple_pvc_interface
branch
from
c48a24d to
1eb769a
Compare
fmount
changed the title
|
/test glance-operator-build-deploy-kuttl |
1 similar comment
|
/test glance-operator-build-deploy-kuttl |
|
/retest-required |
fmount
force-pushed
the
simple_pvc_interface
branch
2 times, most recently
from
d9fcaf0 to
8f314f2
Compare
Do not automatically create an image-conversion PVC when Ceph is set as a backend. It will be documented that the requestSize should be bigger for the default PVC or other strategies should be used (e.g. NFS share attached to the Pods via extraMounts). This patch removes the automation that automatically created an image-conversion PVC. Signed-off-by: Francesco Pantano <[email protected]>
We currently provide both StorageClass and StorageRequest that can be propagated to the underlying instances. However, it might be possible that operators use extraMounts to plug a NFS share mapped to /var/lib/glance. In this case, the API should be updated to not provision any PVC and let the human operator to take care about it using the extraMounts interface. This patch adds a "Storage" struct that is supposed to act as the high level interface where the storage strategy for glance is specified. If the ephemeral boolean is set, no PVCs are provisioned. Signed-off-by: Francesco Pantano <[email protected]>
This reverts commit dbc4480.
The Ephemeral bool field has been added to the API and propagated to the GetVolumeMounts function: this allows to skip both the PVC creation and mount, making glance stateless from a storage point of view. Persistent should be provided by human operator via extraMounts. Signed-off-by: Francesco Pantano <[email protected]>
We currently provide both StorageClass and StorageRequest that can be propagated to the underlying instances. However, it might be possible that operators use extraMounts to plug a NFS share mapped to /var/lib/glance. In this case, the API should be updated to not provision any PVC and let the human operator to take care about it using the extraMounts interface. This patch adds a "Storage" struct that is supposed to act as the high level interface where the storage strategy for glance is specified. If the ephemeral boolean is set, no PVCs are provisioned. Signed-off-by: Francesco Pantano <[email protected]>
Signed-off-by: Francesco Pantano <[email protected]>
Design decision doc lacks of a Storage Requirements section where the PVCs usage is described. This patch helps fixing this part and clarify how they are used in Glance. Signed-off-by: Francesco Pantano <[email protected]>
Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
simple_pvc_interface
branch
from
8f314f2 to
d34128b
Compare
abays
reviewed
Jun 17, 2024
Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
simple_pvc_interface
branch
from
d34128b to
2c095ba
Compare
abays
reviewed
Jun 17, 2024
ack thank you, I think I asked @konan-abhi to review and he was ok w/ this change, but we can wait for him to re-approve. Thank you @abays ! |
konan-abhi
approved these changes
Jun 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 90d7bb7
into
openstack-k8s-operators:main
7 checks passed
fmount
added a commit
to fmount/architecture
that referenced
this pull request
Jun 20, 2024
We recently merged [1][2] and the Glance API have been updated to reflect the new storage interface. This patch aligns architectures repo CRs with the new structure. [1] openstack-k8s-operators/glance-operator#554 [2] openstack-k8s-operators/openstack-operator#843 Jira: https://issues.redhat.com/browse/OSPRH-6719 Signed-off-by: Francesco Pantano <[email protected]>
softwarefactory-project-zuul bot
added a commit
to openstack-k8s-operators/architecture
that referenced
this pull request
Jun 20, 2024
Update glance storageClass propagation We recently merged [1][2] and the Glance API have been updated to reflect the new storage interface. This patch aligns architectures repo CRs with the new structure. [1] openstack-k8s-operators/glance-operator#554 [2] openstack-k8s-operators/openstack-operator#843 Jira: https://issues.redhat.com/browse/OSPRH-6719 Reviewed-by: Andrew Bays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the way we build the storage interface for glance.
In general
Glancerequires astaging areato manipulate data during an import operation.It is possible to copy image data into multiple stores using image import workflow, and all the
import methodsandpluginsare based on this flow, hence some persistence is required forthe resulting Glance
Pod.With this PR, a
Storagestruct is exposed by theglance-operatorAPI, and it helps to choosethe best layout for a particular
glanceAPI.When defining the storage requirements for a
GlanceAPI, with this patch is possible to choosebetween two different models:
Externalmeans that no PVCs are provisioned by the operator, and the human administrator shouldtake care about providing persistence via
ExtraMounts.PVCis still the default interface, and theyare provisioned by the operator.
Jira: https://issues.redhat.com/browse/OSPRH-6719
Depends-On: openstack-k8s-operators/openstack-operator#843