Update openstack_kuttl target to support initialization resource #981
Conversation
Makefile
Outdated
| @@ -2028,6 +2028,9 @@ openstack_kuttl_run: ## runs kuttl tests for the openstack operator, assumes tha | |||
| .PHONY: openstack_kuttl | |||
| openstack_kuttl: export NAMESPACE = ${OPENSTACK_KUTTL_NAMESPACE} | |||
| openstack_kuttl: input deploy_cleanup openstack openstack_deploy_prep ## runs kuttl tests for the openstack operator. Installs openstack operator and cleans up previous deployments before running the tests, cleans up after running the tests. | |||
| # Wait until OLM installs openstack CRDs | |||
| timeout $(TIMEOUT) bash -c "while ! (oc get crd | grep openstack.org); do sleep 1; done" | |||
| bash -c 'oc get crd openstacks.operator.openstack.org && make openstack_init' | |||
There was a problem hiding this comment.
Won't the call to make openstack_init be a problem here until [1] merges? openstack_init assumes that the new initialization sample config is available in the OpenStack operator repo [2]. I think that would throw an error until [1] merges.
[1] openstack-k8s-operators/openstack-operator#1185
[2]
Lines 746 to 747 in b6028e3
Jira: OSPRH-11244
dprince
force-pushed
the
openstack_kuttl_init
branch
from
b52d480 to
b1f931e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9209b18657eb4403b10167dc72272717 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 57s |
|
recheck |
openshift-merge-bot
bot
merged commit 5075cd2
into
openstack-k8s-operators:main
Jira: OSPRH-11244