Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate transport_url and check if every cell have separate one #652

Closed
mrkisaolamb opened this issue Jan 18, 2024 · 1 comment · Fixed by #653
Closed

Validate transport_url and check if every cell have separate one #652

mrkisaolamb opened this issue Jan 18, 2024 · 1 comment · Fixed by #653
Assignees
@mrkisaolamb

Comments

@mrkisaolamb
Copy link
Contributor

Probably we need to validate it in webhook or in nova reconciler
@gibizer
Copy link
Contributor

gibizer commented Jan 18, 2024 •
edited
Loading

I think we can validate that every CellTemplate in NovaSpec.cellTemplates has a unique CellTemplate.CellMessageBusInstance field value. If / when we have rabbit vhost support we can probably remove this limitation and use different vhosts per rabbit instead.

@mrkisaolamb mrkisaolamb self-assigned this Jan 18, 2024
@mrkisaolamb mrkisaolamb linked a pull request Jan 18, 2024 that will close this issue
Validate cellMessageBusInstance to be uniq per cell #653
Merged
@gibizer gibizer mentioned this issue Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrkisaolamb mrkisaolamb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate cellMessageBusInstance to be uniq per cell mrkisaolamb/nova-operator
2 participants
@gibizer @mrkisaolamb