Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate cellMessageBusInstance to be uniq per cell #653

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Validate cellMessageBusInstance to be uniq per cell #653

merged 1 commit into from
Jan 19, 2024

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Jan 18, 2024 •
edited by gibizer
Loading

Closes: #652

@mrkisaolamb mrkisaolamb requested a review from gibizer January 18, 2024 15:32
@openshift-ci openshift-ci bot requested review from frenzyfriday and stuggi January 18, 2024 15:32
@mrkisaolamb mrkisaolamb linked an issue Jan 18, 2024 that may be closed by this pull request
Validate transport_url and check if every cell have separate one #652
Closed
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/99946f821e5a485aaa2a64966d27811f

✔️ nova-operator-content-provider SUCCESS in 54m 05s
✔️ nova-operator-kuttl SUCCESS in 35m 56s
❌ nova-operator-tempest-multinode RETRY_LIMIT in 3s

gibizer
gibizer reviewed Jan 19, 2024
View reviewed changes
api/v1beta1/nova_webhook.go Show resolved Hide resolved
api/v1beta1/nova_webhook.go Outdated Show resolved Hide resolved
test/functional/validation_webhook_test.go Show resolved Hide resolved
@mrkisaolamb mrkisaolamb requested a review from gibizer January 19, 2024 12:43
gibizer
gibizer approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick improvement!

@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2024
SeanMooney
SeanMooney approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me also

i was going to say you should use a set not a map

and then use cell.name for the errmessage but the memory overhead is trivial so meh this is fine too

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SeanMooney,gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b26319a into openstack-k8s-operators:main Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer approved these changes

@SeanMooney SeanMooney SeanMooney approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@gibizer gibizer

@SeanMooney SeanMooney

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate transport_url and check if every cell have separate one
3 participants
@mrkisaolamb @gibizer @SeanMooney