switch to structured logging

[pinikomarov]

This automatically adds additional fields like reconcile_id etc.. from the controller context.

before :

2023-05-18T01:53:14+03:00 INFO controllers.KeystoneAPI Reconciled Service init successfully

after:

2023-10-18T02:27:44.637+0300 INFO Controllers.NovaNoVNCProxy Successfully reconciled {"control
ler": "novanovncproxy", "controllerGroup": "nova.openstack.org", "controllerKind": "NovaNoVNCProxy", "Nov
aNoVNCProxy": {"name":"nova-cell1-novncproxy","namespace":"openstack"}, "namespace": "openstack", "name":
"nova-cell1-novncproxy", "reconcileID": "93d8ab7c-76f0-45ed-9981-f925fef21ae7", "instance": {"apiVersion
": "nova.openstack.org/v1beta1", "kind": "NovaNoVNCProxy", "namespace": "openstack", "name": "nova-cell1-
novncproxy"}}

*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.

[openshift-ci]

Hi @pinikomarov. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/13855129374f4722874b12e8456ce0f2

✔️ nova-operator-content-provider SUCCESS in 1h 27m 52s
❌ nova-operator-kuttl FAILURE in 37m 10s
❌ nova-operator-tempest-multinode FAILURE in 1h 08m 47s

[gibizer]

/ok-to-test

[mrkisaolamb]

Unfortunatly tests are failing with error:
panic: odd number of arguments passed as key-value pairs for logging [recovered] panic: odd number of arguments passed as key-value pairs for logging. Looks like some log texts need to be reformated by fmt.Sprintf

[pinikomarov]

thanks @mrkisaolamb , I have uploaded a fix in all locations I saw a syntax mishap ,
can you point me to the link where that error was printed ? (I can't seem to find that in the tests` logs)

[pinikomarov]

/retest

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c40496857e6a480d855dc90cad749a94

✔️ nova-operator-content-provider SUCCESS in 2h 12m 30s
✔️ nova-operator-kuttl SUCCESS in 38m 14s
❌ nova-operator-tempest-multinode FAILURE in 1h 54m 08s

[mrkisaolamb]

thanks @mrkisaolamb , I have uploaded a fix in all locations I saw a syntax mishap , can you point me to the link where that error was printed ? (I can't seem to find that in the tests` logs)

hey @pinikomarov I run locally GINKGO_ARGS="--output-interceptor-mode=none" make test to got full error output. Now I see that syntax is fixed, thanks!

[bogdando]

lgtm

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/28645cfcb3a44956885e212f192b52a9

✔️ nova-operator-content-provider SUCCESS in 2h 59m 03s
✔️ nova-operator-kuttl SUCCESS in 37m 33s
❌ nova-operator-tempest-multinode FAILURE in 2h 20m 27s

[mrkisaolamb]

recheck

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb, pinikomarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment