Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: multiple related images with the same image ref #613

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix: multiple related images with the same image ref #613

merged 1 commit into from
Dec 1, 2023

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Dec 1, 2023 •
edited by gibizer
Loading

Cherry pick from #612

@openshift-ci openshift-ci bot added the approved label Dec 1, 2023
gibizer
gibizer requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change this as well
https://github.com/openstack-k8s-operators/nova-operator/blob/main/config/default/manager_default_images.yaml#L24-L25

@mrkisaolamb
Copy link
Contributor Author

I think we need to change this as well https://github.com/openstack-k8s-operators/nova-operator/blob/main/config/default/manager_default_images.yaml#L24-L25

in dev-preview2 we don't have this value https://github.com/openstack-k8s-operators/nova-operator/blob/dev-preview2/config/default/manager_default_images.yaml

@mrkisaolamb mrkisaolamb requested a review from gibizer December 1, 2023 08:54
@openshift-ci openshift-ci bot added the lgtm label Dec 1, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer
Copy link
Contributor

gibizer commented Dec 1, 2023

/hold waiting for #612 to land on main first

@gibizer
Copy link
Contributor

gibizer commented Dec 1, 2023

/unhold patch merged on main

@gibizer
Copy link
Contributor

gibizer commented Dec 1, 2023

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 4b57434 into openstack-k8s-operators:dev-preview2 Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@jamepark4 jamepark4 Awaiting requested review from jamepark4

Assignees

@gibizer gibizer

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkisaolamb @gibizer