Add support for KSM #1056

paramite · 2024-09-10T08:50:12Z

This patch add default image and TLS support for kube-state-metrics, a new component of Telemetry/Ceilometer resource.

Related: OBSDA-574
Related: OSPRH-1052
Closes: OSPRH-11115

softwarefactory-project-zuul · 2024-09-10T09:08:25Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/telemetry-operator#337 is needed.

softwarefactory-project-zuul · 2024-10-10T10:20:02Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/telemetry-operator for 337,7a5096b1cfcbc4cfc34a8a28fc3efca226fb3d5f

paramite · 2024-10-10T10:31:53Z

recheck

paramite · 2024-10-10T12:21:50Z

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul · 2024-10-10T12:33:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3a8edbee473408fa4dc6a00933a3393

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 20s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 03m 25s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 05m 18s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 1h 09m 51s
❌ openstack-operator-tempest-multinode FAILURE in 1h 09m 01s

paramite · 2024-10-10T13:51:09Z

/test openstack-operator-build-deploy-kuttl

softwarefactory-project-zuul · 2024-10-11T08:52:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a6512f9c32cc4c669e6eb80f44efa09b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 18s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 06m 22s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 10m 55s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 1h 11m 33s
❌ openstack-operator-tempest-multinode FAILURE in 1h 12m 04s

softwarefactory-project-zuul · 2024-10-11T14:40:31Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ed3cbe5bb1164d639ec157cf429fd6ff

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 14s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 06m 14s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 15m 32s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 1h 13m 08s
❌ openstack-operator-tempest-multinode FAILURE in 1h 09m 07s

softwarefactory-project-zuul · 2024-10-14T09:46:42Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 1056,6b48a538a9025e8cc451339acc1c11e9a10e9c63

paramite · 2024-10-14T10:32:27Z

/retest

softwarefactory-project-zuul · 2024-10-14T12:14:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/af93f350b0244336bb58530b9512776c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 37s
❌ podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 02m 36s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 16m 16s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 1h 12m 00s
❌ openstack-operator-tempest-multinode FAILURE in 1h 07m 34s

dprince · 2024-10-18T10:46:05Z

looks good to me

abays

/lgtm

This patch add default image and TLS support for kube-state-metrics, a new component of Telemetry/Ceilometer resource. Related: OBSDA-574 Related: OSPRH-1052 Closes: OSPRH-11115

softwarefactory-project-zuul · 2025-01-17T22:53:48Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2d22ed74bfbc4b70abd47344ca2b17db

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 53s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 42m 31s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 18s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 59m 59s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 46m 48s

paramite · 2025-01-20T13:30:20Z

recheck

softwarefactory-project-zuul · 2025-01-20T16:48:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/63fe6c15d16149c2b905b5acf63ddb25

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 16m 58s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 28m 38s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 02m 24s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 12s

paramite · 2025-01-20T17:04:48Z

recheck

openshift-ci · 2025-01-21T12:13:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, dprince, paramite

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays,dprince]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

paramite · 2025-01-22T08:11:48Z

/test openstack-operator-build-deploy-kuttl

paramite · 2025-01-22T10:08:20Z

/test openstack-operator-build-deploy-kuttl

paramite · 2025-01-22T11:25:15Z

/test openstack-operator-build-deploy-kuttl

paramite · 2025-01-22T12:23:18Z

/test openstack-operator-build-deploy-kuttl

rabi · 2025-01-22T12:34:27Z

I see a nil pointer dereferencing error in this PR everytime. We're probably trying to derefence an image pointer when the openstackversion status does not have it maybe.

2025-01-22T11:54:57.876Z	INFO	Observed a panic in reconciler: runtime error: invalid memory address or nil pointer dereference	{"controller": "openstackcontrolplane", "controllerGroup": "core.openstack.org", "controllerKind": "OpenStackControlPlane", "OpenStackControlPlane": {"name":"openstack-galera","namespace":"openstack"}, "namespace": "openstack", "name": "openstack-galera", "reconcileID": "d4d06dce-98eb-4ddf-9f55-129204a41d9d"}
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1ab6bc3]

goroutine 925 [running]:
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile.func1()
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:116 +0x1e5
panic({0x1d578e0?, 0x3498d60?})
	/usr/lib/golang/src/runtime/panic.go:914 +0x21f
github.com/openstack-k8s-operators/openstack-operator/pkg/openstack.ReconcileTelemetry.func1()
	/remote-source/pkg/openstack/telemetry.go:327 +0x483
sigs.k8s.io/controller-runtime/pkg/controller/controllerutil.mutate(0x1d37be0?, {{0xc00067d170?, 0x206a1b7?}, {0xc00067d160?, 0x23fd918?}}, {0x2419b08, 0xc0002d7400})
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/controller/controllerutil/controllerutil.go:426 +0x49
sigs.k8s.io/controller-runtime/pkg/controller/controllerutil.CreateOrPatch({0x23fd918, 0xc00518d5f0}, {0x24090c0, 0xc0001427e0}, {0x2419b08?, 0xc0002d7400}, 0xc0043ce728)
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/controller/controllerutil/controllerutil.go:361 +0x493
github.com/openstack-k8s-operators/openstack-operator/pkg/openstack.ReconcileTelemetry({0x23fd918, 0xc00518d5f0}, 0xc003ece800, 0xc00107d800, 0xc000791550)
	/remote-source/pkg/openstack/telemetry.go:310 +0x1fa5
github.com/openstack-k8s-operators/openstack-operator/controllers/core.(*OpenStackControlPlaneReconciler).reconcileNormal(0x2400d08?, {0x23fd918, 0xc00518d5f0}, 0x2418758?, 0xc00107d800?, 0x24090c0?)
	/remote-source/controllers/core/openstackcontrolplane_controller.go:407 +0x47a
github.com/openstack-k8s-operators/openstack-operator/controllers/core.(*OpenStackControlPlaneReconciler).Reconcile(0xc00028f410, {0x23fd918?, 0xc00518d5f0}, {{{0xc000843670?, 0x5?}, {0xc000843660?, 0xc000ca2d08?}}})
	/remote-source/controllers/core/openstackcontrolplane_controller.go:229 +0xacf
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0x2400d08?, {0x23fd918?, 0xc00518d5f0?}, {{{0xc000843670?, 0xb?}, {0xc000843660?, 0x0?}}})
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119 +0xb7
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc00068d040, {0x23fd950, 0xc00012b360}, {0x1e3b900?, 0xc00035a640?})
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316 +0x3cc
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc00068d040, {0x23fd950, 0xc00012b360})
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266 +0x1af
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227 +0x79
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2 in goroutine 173
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:223 +0x565

paramite · 2025-01-22T13:19:56Z

Oh, thanks for the heads-up Rabi, I missed that. I wonder what had changed since yesterday when KUTTL tests were passing? I'm going to look into it.

openshift-ci · 2025-01-22T13:44:21Z

New changes are detected. LGTM label has been removed.

paramite · 2025-01-23T13:38:06Z

/test openstack-operator-build-deploy-kuttl

openshift-ci bot requested review from fao89 and frenzyfriday September 10, 2024 08:50

paramite force-pushed the ksm branch from 9cdd656 to 68fd10e Compare October 10, 2024 10:19

paramite force-pushed the ksm branch from 68fd10e to 460e287 Compare October 11, 2024 07:23

paramite force-pushed the ksm branch from 460e287 to 0828f2f Compare October 11, 2024 13:12

openshift-merge-robot added the needs-rebase label Oct 12, 2024

paramite force-pushed the ksm branch from 0828f2f to 6b48a53 Compare October 14, 2024 09:46

paramite force-pushed the ksm branch from 6b48a53 to a71d045 Compare October 14, 2024 09:52

openshift-merge-robot removed the needs-rebase label Oct 14, 2024

paramite force-pushed the ksm branch 2 times, most recently from 6c09bc6 to f36d7b8 Compare October 17, 2024 08:56

paramite requested review from jlarriba and vyzigold October 17, 2024 14:41

paramite force-pushed the ksm branch from f36d7b8 to 5f6f1e1 Compare October 18, 2024 09:02

abays approved these changes Oct 18, 2024

View reviewed changes

openshift-ci bot assigned abays Oct 18, 2024

openshift-ci bot added lgtm approved labels Oct 18, 2024

KSM

0acdfe6

This patch add default image and TLS support for kube-state-metrics, a new component of Telemetry/Ceilometer resource. Related: OBSDA-574 Related: OSPRH-1052 Closes: OSPRH-11115

paramite force-pushed the ksm branch from b3af7e9 to 0acdfe6 Compare January 17, 2025 19:37

dprince approved these changes Jan 21, 2025

View reviewed changes

openshift-ci bot assigned dprince Jan 21, 2025

openshift-ci bot added the lgtm label Jan 21, 2025

abays removed the do-not-merge/hold label Jan 21, 2025

paramite removed request for jlarriba, vyzigold, fao89 and frenzyfriday January 21, 2025 13:34

openshift-ci bot removed the lgtm label Jan 22, 2025

Initialize KSM image for nil value

1a29e9f

paramite force-pushed the ksm branch from 64ce0b4 to 1a29e9f Compare January 22, 2025 13:45

bshephar mentioned this pull request Jan 23, 2025

Update openstack-k8s-operators (main) #1265

Open

1 task

abays added the lgtm label Jan 23, 2025

openshift-merge-bot bot merged commit 079542b into openstack-k8s-operators:main Jan 23, 2025
8 checks passed

paramite deleted the ksm branch January 24, 2025 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for KSM #1056

Add support for KSM #1056

paramite commented Sep 10, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Sep 10, 2024

softwarefactory-project-zuul bot commented Oct 10, 2024

paramite commented Oct 10, 2024

paramite commented Oct 10, 2024

softwarefactory-project-zuul bot commented Oct 10, 2024

paramite commented Oct 10, 2024

softwarefactory-project-zuul bot commented Oct 11, 2024

softwarefactory-project-zuul bot commented Oct 11, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

paramite commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

dprince commented Oct 18, 2024

abays left a comment

softwarefactory-project-zuul bot commented Jan 17, 2025

paramite commented Jan 20, 2025

softwarefactory-project-zuul bot commented Jan 20, 2025

paramite commented Jan 20, 2025

openshift-ci bot commented Jan 21, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

rabi commented Jan 22, 2025

paramite commented Jan 22, 2025 •

edited

Loading

openshift-ci bot commented Jan 22, 2025

paramite commented Jan 23, 2025

Add support for KSM #1056

Add support for KSM #1056

Conversation

paramite commented Sep 10, 2024 • edited Loading

softwarefactory-project-zuul bot commented Sep 10, 2024

softwarefactory-project-zuul bot commented Oct 10, 2024

paramite commented Oct 10, 2024

paramite commented Oct 10, 2024

softwarefactory-project-zuul bot commented Oct 10, 2024

paramite commented Oct 10, 2024

softwarefactory-project-zuul bot commented Oct 11, 2024

softwarefactory-project-zuul bot commented Oct 11, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

paramite commented Oct 14, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

dprince commented Oct 18, 2024

abays left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jan 17, 2025

paramite commented Jan 20, 2025

softwarefactory-project-zuul bot commented Jan 20, 2025

paramite commented Jan 20, 2025

openshift-ci bot commented Jan 21, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

paramite commented Jan 22, 2025

rabi commented Jan 22, 2025

paramite commented Jan 22, 2025 • edited Loading

openshift-ci bot commented Jan 22, 2025

paramite commented Jan 23, 2025

paramite commented Sep 10, 2024 •

edited

Loading

paramite commented Jan 22, 2025 •

edited

Loading