[OSPRH-12378] Set X-Forwarded-Proto only if empty

[jlarriba]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlarriba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlarriba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vyzigold]

This looks good, but I'm wondering if we need something similar for aodh

telemetry-operator/templates/autoscaling/config/wsgi-aodh.conf

Line 22 in 1bc386e

{{- if $vhost.TLS }}

[jlarriba]

This looks good, but I'm wondering if we need something similar for aodh

telemetry-operator/templates/autoscaling/config/wsgi-aodh.conf

Line 22 in 1bc386e

{{- if $vhost.TLS }}

That conf file is currently lacking the line we are replacing:

telemetry-operator/templates/ceilometercentral/config/httpd.conf

Line 37 in 1bc386e

RequestHeader set X-Forwarded-Proto "https"

I wonder if this was a bug or intended.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b30c45477d4b47a997af0a49f243b39d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 15s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 08m 55s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 16m 48s
✔️ telemetry-operator-multinode-power-monitoring SUCCESS in 45m 43s
❌ functional-tests-on-osp18 FAILURE in 1h 51m 48s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 06m 15s
❌ functional-graphing-tests-osp18 FAILURE in 1h 05m 19s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 36s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2504793ae7b8467ea573663c969bb67c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 25s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 06m 17s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 15m 43s
✔️ telemetry-operator-multinode-power-monitoring SUCCESS in 59m 46s
❌ functional-tests-on-osp18 FAILURE in 1h 52m 49s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 07m 50s
❌ functional-graphing-tests-osp18 FAILURE in 59m 59s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 06m 24s

[jlarriba]

recheck

It is an issue deploying the dataplane deployment: This task (Wait until the osdpd is redeployed to continue) failed

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ef73603c09c4cd8b5e248ebed29a545

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 15s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 05m 01s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 18m 28s
✔️ telemetry-operator-multinode-power-monitoring SUCCESS in 47m 40s
❌ functional-tests-on-osp18 FAILURE in 1h 49m 08s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 03m 48s
❌ functional-graphing-tests-osp18 FAILURE in 1h 02m 18s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 38s