Move number of points to file details in gpx emails

openstreetmap · Jan 11, 2025 · be8d769 · be8d769
1 parent a6c6f26
commit be8d769
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 5 deletions.
diff --git a/app/views/user_mailer/_gpx_description.html.erb b/app/views/user_mailer/_gpx_description.html.erb
@@ -13,4 +13,12 @@
     <dt><%= t ".tags" %>
     <dd><%= @trace_tags.map(&:tag).join(", ") %>
   <% end %>
+  <% if @possible_points %>
+    <dt><%= t ".total_points" %>
+    <dd><%= @possible_points %>
+  <% end %>
+  <% if @trace_points %>
+    <dt><%= t ".imported_points" %>
+    <dd><%= @trace_points %>
+  <% end %>
 </dl>
diff --git a/app/views/user_mailer/_gpx_description.text.erb b/app/views/user_mailer/_gpx_description.text.erb
@@ -12,3 +12,11 @@
 <%= t ".tags" %>
 	<%= @trace_tags.map(&:tag).join(", ") %>
 <% end %>
+<% if @possible_points %>
+<%= t ".total_points" %>
+	<%= @possible_points %>
+<% end %>
+<% if @trace_points %>
+<%= t ".imported_points" %>
+	<%= @trace_points %>
+<% end %>
diff --git a/app/views/user_mailer/gpx_success.html.erb b/app/views/user_mailer/gpx_success.html.erb
@@ -1,6 +1,6 @@
 <p><%= t ".hi", :to_user => @to_user %></p>
 
-<p><%= t ".loaded_successfully", :trace_points => @trace_points, :count => @possible_points %>
+<p><%= t ".imported_successfully" %></p>
 
 <%= render :partial => "gpx_description" %>
 

diff --git a/app/views/user_mailer/gpx_success.text.erb b/app/views/user_mailer/gpx_success.text.erb
@@ -1,6 +1,6 @@
 <%= t ".hi", :to_user => @to_user %>
 
-<%= t ".loaded_successfully", :trace_points => @trace_points, :count => @possible_points %>
+<%= t ".imported_successfully" %>
 
 <%= render :partial => "gpx_description" %>
 

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1674,6 +1674,8 @@ en:
       url: URL
       description: Description
       tags: Tags
+      total_points: Total number of points
+      imported_points: Number of imported points
     gpx_failure:
       hi: "Hi %{to_user},"
       failed_to_import: "It looks like your file failed to be imported as a GPS trace."
@@ -1684,9 +1686,7 @@ en:
       subject: "[OpenStreetMap] GPX Import failure"
     gpx_success:
       hi: "Hi %{to_user},"
-      loaded_successfully:
-        one: "It looks like your file loaded successfully with %{trace_points} out of a possible %{count} point."
-        other: "It looks like your file loaded successfully with %{trace_points} out of a possible %{count} points."
+      imported_successfully: "It looks like your file was imported successfully as a GPS trace."
       all_your_traces: "All your successfully uploaded GPX traces can be found at %{url}"
       all_your_traces_html: "All your successfully uploaded GPX traces can be found at %{url}."
       subject: "[OpenStreetMap] GPX Import success"