Replace query marker fade animation with css #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
css-query-animation
branch
from
ececb8b to
4613119
Compare
tomhughes
reviewed
Nov 7, 2024
There was a problem hiding this comment.
This is great, but despite the time being set the same it definitely seems to run faster to me? It's hard to actually time it but it seems like it might be close to twice as fast maybe because the javascript introduces extra delays running the function?
I think we should probably increase the time in the CSS to somewhere nearer 1500 to get closer to the same behaviour.
AntonKhorev
force-pushed
the
css-query-animation
branch
from
4613119 to
771b75e
Compare
|
Increased to 1500ms. Javascript event listeners run in the same thread with everything else including getting query results over the net. |
|
This looks good now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5305.
Currently query markers are animated using javascript which requires managing timed events. We don't do it correctly, we don't cancel them when markers are removed. That's why #5305 happens.
This PR replaces the javascript animation with the css which doesn't require any event handlers. I could have added animation end events to remove the marker layer but once faded out it doesn't affect anything and it's cleaned up in
page.unload.