Add subscribe/unsubscribe buttons to note pages #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
reviewed
Nov 21, 2024
There was a problem hiding this comment.
This mostly looks good - my only question would be about error handling for subscribe/unsubscribe as the error text reporting has been moved to only happen for the comment button.
The equivalent code for changesets reports the error in all cases by the looks of it - you can certainly argue that putting the text under the comment box in that case is not ideal but it's probably better than not showing it and errors should be very rare.
AntonKhorev
force-pushed
the
note-subscriptions-buttons
branch
from
b88e3f7 to
aca9bd2
Compare
|
Enabled showing errors for (un)subscribe buttons. I didn't want to do this because the most likely error is that you're blocked and your access to the api is removed. But we shouldn't block people from unsubscribing. I thought that maybe I'll allow that first. |
tomhughes
approved these changes
Nov 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 5 of #5283 that adds the button to subscribe/unsubscribe from a note.