Use resourceful routes for terms view/accept/decline #5462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /user/terms
changed toGET /account/terms
. It's inconvenient to have it at/user/terms
because that depends on the declaration order. If user resources are declared first, they captureterms
as a username. I still add a redirect from/user/terms
to/account/terms
which has to come beforeresources :users
, but with redirects it's obvious that they are temporary.POST /user/save
changed toPUT /account/terms
. Withuser#save
it's not clear that this is a target of the terms form.