-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dark map tiles in embed #5519
base: master
Are you sure you want to change the base?
Conversation
Also, has this file never been linted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to avoid including stylistic changes like replacing single quotes with double quotes in the same commit as functional changes as it makes it very hard to tell what the actual functional changes are when reviewing...
Just doing the same linting as usual, why is this not wanted now @tomhughes? |
Firstly I didn't say it wasn't wanted, I said it is better to keep it in a separate commit to make reviewing easier. Secondly what "same linting as usual" is this? As far as I know it was already passing our eslint rules so is this some additional linting of your own? |
So, when I tested the changes locally, I edited the evaluated JS to make iteration faster for me. Then the linter got mad. But eslint alone doesn't check files that have embedded ruby, which I'll criticise in an issue later on. |
See also #5523 |
Generated by 🚫 Danger |
This PR
Doesn't touch the CSS though.