Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dark map tiles in embed #5519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hlfan
Copy link
Contributor

@hlfan hlfan commented Jan 19, 2025

This PR

  • Adds layer type switching based on a new theme parameter and prefers-color-scheme
  • Rewrites argument extraction and application of layer and bbox
  • Lints this file apparently for the first time

Doesn't touch the CSS though.

Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to avoid including stylistic changes like replacing single quotes with double quotes in the same commit as functional changes as it makes it very hard to tell what the actual functional changes are when reviewing...

@hlfan
Copy link
Contributor Author

hlfan commented Jan 19, 2025

Just doing the same linting as usual, why is this not wanted now @tomhughes?

@tomhughes
Copy link
Member

Firstly I didn't say it wasn't wanted, I said it is better to keep it in a separate commit to make reviewing easier.

Secondly what "same linting as usual" is this? As far as I know it was already passing our eslint rules so is this some additional linting of your own?

@hlfan
Copy link
Contributor Author

hlfan commented Jan 19, 2025

So, when I tested the changes locally, I edited the evaluated JS to make iteration faster for me. Then the linter got mad. But eslint alone doesn't check files that have embedded ruby, which I'll criticise in an issue later on.
As I don't like touching and "un-touching" code, I guess I'll keep making PRs.

@hlfan
Copy link
Contributor Author

hlfan commented Jan 20, 2025

See also #5523

@hlfan hlfan reopened this Jan 24, 2025
Copy link

1 Warning
⚠️ Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md.

Generated by 🚫 Danger

@hlfan hlfan mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants