Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: biosample id duplication #822

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: biosample id duplication #822

merged 3 commits into from
Oct 7, 2024

Conversation

Tobi1kenobi
Copy link
Contributor

@Tobi1kenobi Tobi1kenobi commented Oct 7, 2024 •
edited
Loading

✨ Context

🛠 What does this PR implement

Fixes the bug and implements some additional tests to catch this case in the future

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@Tobi1kenobi Tobi1kenobi requested a review from DSuveges October 7, 2024 14:13
@Tobi1kenobi Tobi1kenobi marked this pull request as ready for review October 7, 2024 14:13
@Tobi1kenobi Tobi1kenobi changed the title Alegbe fix biosample id duplication fix: biosample id duplication Oct 7, 2024
DSuveges
DSuveges approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thank you!

@DSuveges DSuveges merged commit 8b29168 into dev Oct 7, 2024
5 checks passed
@DSuveges DSuveges deleted the alegbe-fix_biosample_id_duplication branch October 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSuveges DSuveges DSuveges approved these changes

Assignees
No one assigned
Labels
Dataset size-S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobi1kenobi @DSuveges