[Platform]: fix the evidence page and publication across UI (#587)

* fix: evidence page * fix: publication issues
opentargets · Dec 2, 2024 · dbc942b · dbc942b
1 parent d4d36a6
commit dbc942b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/packages/sections/src/evidence/GWASCredibleSets/Body.jsx b/packages/sections/src/evidence/GWASCredibleSets/Body.jsx
@@ -18,7 +18,7 @@ import { dataTypesMap } from "../../dataTypes";
 import GWAS_CREDIBLE_SETS_QUERY from "./sectionQuery.gql";
 import { mantissaExponentComparator } from "../../utils/comparators";
 
-function getColumns() {
+function getColumns(targetSymbol) {
   return [
     {
       id: "credibleSet",
@@ -51,9 +51,7 @@ function getColumns() {
       id: "study",
       label: "Study",
       renderCell: ({ credibleSet }) => {
-        return (
-          <Link to={`/study/${credibleSet?.study.id}`}>{credibleSet?.study.id}</Link>
-        );
+        return <Link to={`/study/${credibleSet?.study.id}`}>{credibleSet?.study.id}</Link>;
       },
     },
     {
@@ -104,7 +102,8 @@ function getColumns() {
       id: "confidence",
       label: "Fine-mapping confidence",
       sortable: true,
-      tooltip: "Fine-mapping confidence based on the quality of the linkage-desequilibrium information available and fine-mapping method",
+      tooltip:
+        "Fine-mapping confidence based on the quality of the linkage-desequilibrium information available and fine-mapping method",
       renderCell: ({ credibleSet }) => {
         if (!credibleSet?.confidence) return naLabel;
         return (
@@ -148,11 +147,13 @@ function getColumns() {
     {
       id: "publication",
       label: "Publication",
-      renderCell: ({ credibleSet }) => {
+      renderCell: ({ credibleSet, disease }) => {
         const { publicationFirstAuthor, publicationDate, pubmedId } = credibleSet?.study ?? {};
         if (!publicationFirstAuthor) return naLabel;
         return (
           <PublicationsDrawer
+            name={disease.name}
+            symbol={targetSymbol}
             entries={[{ name: pubmedId }]}
             customLabel={`${publicationFirstAuthor} et al. (${new Date(
               publicationDate
@@ -170,7 +171,7 @@ function Body({ id, label, entity }) {
   const { ensgId, efoId } = id;
   const variables = { ensemblId: ensgId, efoId, size: sectionsBaseSizeQuery };
 
-  const columns = getColumns();
+  const columns = getColumns(label.symbol);
 
   const request = useQuery(GWAS_CREDIBLE_SETS_QUERY, {
     variables,

diff --git a/packages/sections/src/evidence/GWASCredibleSets/Summary.jsx b/packages/sections/src/evidence/GWASCredibleSets/Summary.jsx
@@ -20,7 +20,7 @@ function Summary() {
 }
 
 Summary.fragments = {
-  GWASCredibleSetsSummaryFragment: GWAS_CREDIBLE_SETS_SUMMARY_FRAGMENT,
+  EvidenceGWASCredibleSetsSummaryFragment: GWAS_CREDIBLE_SETS_SUMMARY_FRAGMENT,
 };
 
 export default Summary;
diff --git a/packages/ui/src/components/PublicationsDrawer/PublicationWrapper.jsx b/packages/ui/src/components/PublicationsDrawer/PublicationWrapper.jsx
@@ -161,7 +161,7 @@ function PublicationWrapper({
         </Box>
       )}
 
-      {fullTextOpen && isOpenAccess && urlAiApi && (
+      {symbol && name && fullTextOpen && isOpenAccess && urlAiApi && (
         <PublicationSummary name={name} symbol={symbol} pmcId={pmcId} />
       )}
     </Box>
-Original file line number
+Diff line change
@@ Expand Up / @@ -161,7 +161,7 @@ function PublicationWrapper({ @@
             </Box>
           )}
-          {fullTextOpen && isOpenAccess && urlAiApi && (
+          {symbol && name && fullTextOpen && isOpenAccess && urlAiApi && (
             <PublicationSummary name={name} symbol={symbol} pmcId={pmcId} />
           )}
         </Box>
@@ Expand Down @@