Fix delegate info methods to return correct values #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opentensor#2564 Fix the issue with `bt_decode.DelegateInfo.decode_vec` in `bittensor/core/chain_data/delegate_info.py` to handle the decoding of `vec_u8` correctly. * Add a new method `from_vec_u8` to decode `vec_u8` and return a `DelegateInfo` object. * Update the `list_from_vec_u8` method to correctly decode `vec_u8` and return a list of `DelegateInfo` objects. * Ensure that `total_daily_return` and `return_per_1000` are correctly decoded and returned. Update `bittensor/core/chain_data/delegate_info_lite.py` to handle type conversions and ensure correct data types. * Add a new method `from_raw_data` to create a `DelegateInfoLite` instance from raw data with proper type conversions. * Ensure that `registrations` and `validator_permits` are lists of integers. * Ensure that `take` is rounded to 6 decimal places and `nominators`, `return_per_1000`, and `total_daily_return` are integers. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/opentensor/bittensor/issues/2564?shareId=XXXX-XXXX-XXXX-XXXX).
|
You've got some failing tests. Please fix those and I'll have a review. |
|
Sorry i hope to get more familiar with the project in the next day and to offer a valid contribution
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2564
Fix the issue with
bt_decode.DelegateInfo.decode_vecinbittensor/core/chain_data/delegate_info.pyto handle the decoding ofvec_u8correctly.from_vec_u8to decodevec_u8and return aDelegateInfoobject.list_from_vec_u8method to correctly decodevec_u8and return a list ofDelegateInfoobjects.total_daily_returnandreturn_per_1000are correctly decoded and returned.Update
bittensor/core/chain_data/delegate_info_lite.pyto handle type conversions and ensure correct data types.from_raw_datato create aDelegateInfoLiteinstance from raw data with proper type conversions.registrationsandvalidator_permitsare lists of integers.takeis rounded to 6 decimal places andnominators,return_per_1000, andtotal_daily_returnare integers.For more details, open the Copilot Workspace session.