[dnssd] implement otPlatDnssd APIs
#2038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds new methods in `Mdns::Publisher` to publish or unpublish a key record for a given (host or service instance) name. New methods are implemented for both MDNSResponder and Avahi sub-classes. In the MDNSResponder implementation, if a key registration is for a service instance name matching a service registration, `DNSServiceAddRecord()` is used to associate the new record with the service. Otherwise, `DNSServiceRegisterRecord()` is used to register the KEY record on its own. The implementation handles cases when related service and key registrations are updated or unregistered. This commit also simplifies and updates the `test/mdns/main.cpp` tests, adding a common `Test()` function that takes a function pointer to run the test and handles all common boilerplate code, as well as adding a common callback to check the registration result. New test cases are also added to check key registration, registering keys on their own, and registering keys and services in different orders.
This commit adds `DnssPlatform` module which implements OpenThread platform APIs `otPlatDnssd` for registering and unregistering host, service, and key items. This commit also adds a new config `OTBR_DNSSD_PLAT` which enables the new module and ensure its related OT core module are enabled (such as advertising-proxy).
|
Closing this in favor #2042. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
DnssPlatformmodule which implements OpenThread platform APIsotPlatDnssdfor registering and unregistering host, service, and key items. This commit also adds a new configOTBR_DNSSD_PLATwhich enables the new module and ensure its related OT core module are enabled (such as advertising-proxy).PublishKey()&UnpublishKey()methods #2022AdvertisingProxyand defineDnssdplatform APIs openthread#9268