[build] allow disabling systemd service unit install #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Dec 27, 2024
|
(just noting that I made the CLA bot happy, so you can disregard its comment now.) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
===========================================
- Coverage 55.77% 43.38% -12.40%
===========================================
Files 87 108 +21
Lines 6890 13359 +6469
Branches 0 963 +963
===========================================
+ Hits 3843 5796 +1953
- Misses 3047 7255 +4208
- Partials 0 308 +308 ☔ View full report in Codecov by Sentry. |
|
There's a merge conflict now it seems. |
Add `INSTALL_SYSTEMD_UNIT` which can explicitly be set to `false` to disable installing the service unit even if systemd is available. If not defined, it defaults to true, i.e. the systemed service unit is created. As a result, this change is backwards compatible: it's required to _opt-out_ of systemd unit installation.
jwhui
force-pushed
the
milas/cmake-systemd-optout
branch
from
44290c4 to
a5907b1
Compare
jwhui
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
INSTALL_SYSTEMD_UNITwhich can explicitly be set tofalseto disable installing the service unit even if systemd is available.If not defined, it defaults to true, i.e. the systemed service unit is created. As a result, this change is backwards compatible: it's required to opt-out of systemd unit installation.
In particular, this is useful for NixOS, where a systemd unit will be created independently from the CMake build.
See also: