-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform] implement platform dnssd apis #2664
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2664 +/- ##
===========================================
- Coverage 55.77% 43.39% -12.39%
===========================================
Files 87 108 +21
Lines 6890 13359 +6469
Branches 0 963 +963
===========================================
+ Hits 3843 5797 +1954
- Misses 3047 7255 +4208
- Partials 0 307 +307 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
caa5cf8
to
757c9d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍 Couple of questions/suggestions below:
757c9d0
to
f793a6d
Compare
a909787
to
00ecefb
Compare
00ecefb
to
4075f0c
Compare
@jwhui Updated! |
This PR adds
DnssdPlatform
module to implement OT platform DNSSD APIs.This PR follows up the unmerged PR: #2042
This PR is part of the effort to move the BorderAgent MeshCoP Service Publisher into OT core: #2658
In this PR,
DnssdPlatform
is added but not used yet. It will be enabled and used later when the native Border Agent MeshCoP Service publishing is ready.In this PR, these platform DNSSD APIs are implemented while the rest of them has an empty implementation and will be implemented when necessary: