Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] implement platform dnssd apis #2664

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Irving-cl
Copy link
Contributor

This PR adds DnssdPlatform module to implement OT platform DNSSD APIs.

This PR follows up the unmerged PR: #2042

This PR is part of the effort to move the BorderAgent MeshCoP Service Publisher into OT core: #2658

In this PR, DnssdPlatform is added but not used yet. It will be enabled and used later when the native Border Agent MeshCoP Service publishing is ready.

In this PR, these platform DNSSD APIs are implemented while the rest of them has an empty implementation and will be implemented when necessary:

  • otPlatDnssdGetState
  • otPlatDnssdRegisterService
  • otPlatDnssdUnregisterService
  • otPlatDnssdRegisterHost
  • otPlatDnssdUnregisterHost
  • otPlatDnssdRegisterKey
  • otPlatDnssdUnregisterKey

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 43.39%. Comparing base (2b41187) to head (4075f0c).
Report is 922 commits behind head on main.

Files with missing lines Patch % Lines
src/host/posix/dnssd.cpp 0.00% 90 Missing ⚠️
src/host/posix/dnssd.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2664       +/-   ##
===========================================
- Coverage   55.77%   43.39%   -12.39%     
===========================================
  Files          87      108       +21     
  Lines        6890    13359     +6469     
  Branches        0      963      +963     
===========================================
+ Hits         3843     5797     +1954     
- Misses       3047     7255     +4208     
- Partials        0      307      +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ncp/posix/dnssd.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@Irving-cl Irving-cl force-pushed the add_dnssd_platform branch 3 times, most recently from caa5cf8 to 757c9d0 Compare January 14, 2025 02:26
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 Couple of questions/suggestions below:

src/host/posix/dnssd.cpp Show resolved Hide resolved
src/host/posix/dnssd.cpp Show resolved Hide resolved
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl requested a review from jwhui January 16, 2025 02:44
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
src/host/posix/dnssd.hpp Outdated Show resolved Hide resolved
@Irving-cl Irving-cl force-pushed the add_dnssd_platform branch 2 times, most recently from a909787 to 00ecefb Compare January 17, 2025 03:03
@Irving-cl
Copy link
Contributor Author

@jwhui Updated!

@jwhui jwhui merged commit e6c1af6 into openthread:main Jan 21, 2025
32 checks passed
@Irving-cl Irving-cl deleted the add_dnssd_platform branch January 23, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants