Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-8994: Change default client tokens to jwt #287

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Feb 5, 2025

This PR adds the ability to create JWT client tokens and sets this as the default, with the option to create T1 tokens if the user specifies this. Specifically the PR:

  • Updates the token creation logic to accept an optional token_type param in the generate_token method:
    • The param has two acceptable values: 'T1' and 'JWT'
      • If 'T1' is set, a T1 token is generated
      • If 'JWT' is set, or if the token_type param is ommitted, a JWT is generated
  • Updates existing unit tests and add new unit tests to cover the amended and added functionality

@dragonmantank dragonmantank merged commit b6d4bc6 into main Feb 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants