Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geocoder to match latest OTP API #660

Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

The OTP api has changed the response of the geocoder. This PR accounts for that. Breaking change. Older OTP versions are not supported

BREAKING CHANGE: No support for OTP versions older than 2.5.0
@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) label Sep 26, 2023
@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Sep 26, 2023
@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) label Nov 8, 2023
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review November 8, 2023 04:19
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks for the fix

@miles-grant-ibigroup miles-grant-ibigroup merged commit 824a68f into opentripplanner:master Nov 13, 2023
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the otp-geocoder-update branch November 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants